Rework some device and hci functions #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zxzxwu
commented
Jul 16, 2024
zxzxwu
commented
- Add type hints
- Add wait_for_complete behavior for async commands
* Add type hints * Add wait_for_complete behavior for async commands
barbibulle
reviewed
Jul 16, 2024
| max_latency: int, | ||
| supervision_timeout: int, | ||
| use_l2cap: bool = False, | ||
| wait_for_complete: bool = False, |
There was a problem hiding this comment.
maybe wait_for_completion would be a better name for this parameter.
| phy_options: int = 0, | ||
| wait_for_complete: bool = False, | ||
| ) -> None: | ||
| """Sets PHY preference of this connection. |
There was a problem hiding this comment.
Since this docstring is essentially the same as the one for device.set_connection_phy, maybe there's a clever way to just say "See XYZ" and refer to that other location, rather than have a copy of the docstring, which is hard to maintain in both places.
| supervision_timeout=supervision_timeout, | ||
| min_ce_length=min_ce_length, | ||
| max_ce_length=max_ce_length, | ||
| with closing(EventWatcher()) as watcher: |
There was a problem hiding this comment.
suggestion: move the call to self.send_command() to a local function, which the code followibng with closing(...) ...: can invoke, but can also be invoked without the with close when wait_for_completion is False, so that we don't unnecessarily create the context and the future in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.