Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon.ico to docs folder #512

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

AlanRosenthal
Copy link
Collaborator

@AlanRosenthal AlanRosenthal commented Jul 10, 2024

Generated via: realfavicongenerator.net

validated via:

$ icotool -l favicon.ico
--icon --index=1 --width=48 --height=48 --bit-depth=32 --palette-size=0
--icon --index=2 --width=32 --height=32 --bit-depth=32 --palette-size=0
--icon --index=3 --width=16 --height=16 --bit-depth=32 --palette-size=0

@AlanRosenthal
Copy link
Collaborator Author

image

@barbibulle
Copy link
Collaborator

Generated via:

convert ./docs/images/logo.png -resize 16x16 web/favicon.ico

I recommend using a larger size. Browsers will resize it so something smaller depending on usage. Maybe 128x128?

Generated via: realfavicongenerator.net

validated via:
```
$ icotool -l favicon.ico
--icon --index=1 --width=48 --height=48 --bit-depth=32 --palette-size=0
--icon --index=2 --width=32 --height=32 --bit-depth=32 --palette-size=0
--icon --index=3 --width=16 --height=16 --bit-depth=32 --palette-size=0
```
@AlanRosenthal AlanRosenthal changed the title Add favicon to web server Add favicon.ico to docs folder Jul 11, 2024
@AlanRosenthal
Copy link
Collaborator Author

Generated via:

convert ./docs/images/logo.png -resize 16x16 web/favicon.ico

I recommend using a larger size. Browsers will resize it so something smaller depending on usage. Maybe 128x128?

Based on this SO's post I used a generator on realfavicongenerator.net. The file is now in the docs/images folder, and symlinked into the web folder

@barbibulle barbibulle merged commit cb7ca44 into google:main Jul 12, 2024
110 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants