Create inv web.build
#507
Merged
Create inv web.build
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command will build a wheel, copy it in the web directory, and create a file `packageFile` with the name of the wheel. If the correct override param is given, bumble.js will read `packageFile` and load that package.
barbibulle
reviewed
Jul 9, 2024
| newest_wheel = Path(max(glob.glob('dist/*.whl'), key=lambda f: os.path.getmtime(f))) | ||
| shutil.copy(newest_wheel, Path('web/')) | ||
| # Step 3: Write wheel's name to web/packageFile | ||
| with open(Path('web', 'packageFile'), mode='w') as package_file: |
There was a problem hiding this comment.
It might be simpler to just copy the built .whl file to just web/bumble.whl rather than go through the indirection of a text file pointing to the built file.
Then the web page can just reference ?package=bumble.whl.
There was a problem hiding this comment.
Unfortunately doing that results in this error message:
packaging.utils.InvalidWheelFilename: Invalid wheel filename (wrong number of parts): bumble
barbibulle
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will build a wheel, copy it in the web directory, and create a file
packageFilewith the name of the wheel. If the correct override param is given, bumble.js will readpackageFileand load that package.