basic auracast app #489
Merged
basic auracast app #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
reviewed
May 21, 2024
barbibulle
force-pushed
the
gbg/basic-auracast-app
branch
from
f26597b
to
2f2a275
Compare
zxzxwu
reviewed
May 22, 2024
barbibulle
force-pushed
the
gbg/basic-auracast-app
branch
from
8f412dd
to
60d955d
Compare
barbibulle
force-pushed
the
gbg/basic-auracast-app
branch
from
60d955d
to
dea907b
Compare
zxzxwu
reviewed
Jun 4, 2024
Comment on lines
+947
to
+948
| if response.status != HCI_Command_Status_Event.PENDING: | ||
| raise HCI_StatusError(response) |
There was a problem hiding this comment.
Could be replaced with send_command(..., check_result=True) (HCI_SUCCESS and HCI_PENDING are both 0)
There was a problem hiding this comment.
Good point! I now realize that there's a bunch of places in the code base where the same idea applies. I'll make a separate PR to unify that.
zxzxwu
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This app is intended to support auracast features. To start with, only scanning for broadcasts is implemented. More functionality, including sending and receiving broadcasts, will be added in future PRs.