Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hint all examples #470

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Type hint all examples #470

merged 1 commit into from
Apr 15, 2024

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Apr 15, 2024 •
edited
Loading

Replace common legacy patterns:

  • async def main() without return types (so mypy doesn't check the entire function body)
  • String as address
  • HCI transport as iterator

@zxzxwu zxzxwu marked this pull request as ready for review April 15, 2024 14:54
@zxzxwu zxzxwu requested a review from barbibulle April 15, 2024 15:00
@zxzxwu zxzxwu merged commit 51321ca into google:main Apr 15, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxzxwu @barbibulle