Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyusb: powercycle the dongle #468

Merged
merged 2 commits into from
Apr 17, 2024
Merged

pyusb: powercycle the dongle #468

merged 2 commits into from
Apr 17, 2024

Conversation

SilverBzH
Copy link
Collaborator

No description provided.

@SilverBzH SilverBzH force-pushed the charliebout/power_cycle_pyusb_transport branch 6 times, most recently from 59bb428 to a36d222 Compare April 15, 2024 17:24
@SilverBzH SilverBzH marked this pull request as ready for review April 15, 2024 17:27
@SilverBzH
Copy link
Collaborator Author

This PR allows power cycling of PyUSB devices when connected to a hub with port-level power control. Power cycling will be skipped if a compatible hub is not found.

@barbibulle
Copy link
Collaborator

This PR allows power cycling of PyUSB devices when connected to a hub with port-level power control. Power cycling will be skipped if a compatible hub is not found.

the pyusb transport is mostly a legacy implementation. The current/maintained USB transport is is transport/usb.py, implementation based on libusb1 instead of pyusb. Would it make sense to implement this behavior in usb.py instead (or in addition)?

barbibulle
barbibulle reviewed Apr 15, 2024
View reviewed changes
bumble/transport/pyusb.py Outdated Show resolved Hide resolved
bumble/transport/pyusb.py Outdated Show resolved Hide resolved
@SilverBzH
Copy link
Collaborator Author

the pyusb transport is mostly a legacy implementation. The current/maintained USB transport is is transport/usb.py, implementation based on libusb1 instead of pyusb. Would it make sense to implement this behavior in usb.py instead (or in addition)?

We switched to using the pyusb implementation because we encountered issues with the usb one during our testing. We didn't investigate the usb implementation thoroughly before moving to pyusb, as it is performing well in our test environment.

@SilverBzH SilverBzH force-pushed the charliebout/power_cycle_pyusb_transport branch from a36d222 to 39871e8 Compare April 15, 2024 21:42
@SilverBzH SilverBzH merged commit 71df062 into main Apr 17, 2024
51 checks passed
@SilverBzH SilverBzH deleted the charliebout/power_cycle_pyusb_transport branch April 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbibulle barbibulle barbibulle approved these changes

@DeltaEvo DeltaEvo Awaiting requested review from DeltaEvo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilverBzH @barbibulle