open_tcp_server_transport: allow explicit sock as input. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeru
force-pushed
the
main
branch
2 times, most recently
from
c9e26b2
to
e1216d9
Compare
barbibulle
reviewed
Mar 5, 2024
|
Thanks for the suggestion. Indeed that makes the interface cleaner. Refactored accordingly. And sorry for the noob mistakes on the lint and the extra trouble on re-approving the workflows... Was using an outdated "black" which touched too many files, so didn't even notice "invoke project.pre-commit" has multiple stages. |
barbibulle
reviewed
Mar 13, 2024
When a user doesn't need an exact port, but cares more about getting SOME unused port, they can do: * Create a socket outside with port=None or port=0. * Use socket.getsockname()[1] to get the allocated port and pass to the TCP client somehow. * Use the created socket to create a TCP server transport. Use-case: unit-testing embedded software that implements a BLE host. The controller will be a Bumble controller, connected to the host via a TCP channel. * The host will have a TCP-client HCI transport for testing. * The pytest setup code will allocate the TCP server and pass the port number to the host. Also add some unittests with python mock.
|
Any further comments? |
Sorry about that, I forgot the approval was pending. Good to go! |
barbibulle
approved these changes
Apr 5, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user doesn't need an exact port, but cares more about getting SOME unused port, they can do:
Use-case: unit-testing embedded software that implements a BLE host. The controller will be a Bumble controller, connected to the host via a TCP channel.
Also add some unittests with python mock.