Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request MTU change after connection #385

Merged
merged 1 commit into from
Dec 28, 2023
Merged

request MTU change after connection #385

merged 1 commit into from
Dec 28, 2023

Conversation

barbibulle
Copy link
Collaborator

Somehow, Android doesn't negotiate a DLE change unless an MTU change is requested...

AlanRosenthal
AlanRosenthal approved these changes Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@AlanRosenthal AlanRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very interesting - is this an Android bug or just expected behavior?

@barbibulle
Copy link
Collaborator Author

very interesting - is this an Android bug or just expected behavior?
It's a bug as far as I'm concerned. But since there's no user-accessible API to know or control the Data Length of a connection, it's not technically breaking any contracts with developers, it just makes it tricky to know what Data Length you're going to get (and because this behavior is undocumented, it could also change at any point)

@barbibulle barbibulle merged commit 6810865 into main Dec 28, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRosenthal AlanRosenthal AlanRosenthal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barbibulle @AlanRosenthal