Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller: SCO implementation #383

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Controller: SCO implementation #383

merged 1 commit into from
Jan 9, 2024

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Dec 28, 2023

This provides a capability to test SCO virtually. We will also apply the same strategy to CIS.

@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Dec 28, 2023

@barbibulle I suggest we should abandon the support of RemoteLink, so that the type annotation between controller and link would be simpler.

@zxzxwu zxzxwu force-pushed the controller branch 3 times, most recently from c614a0d to 27c70e1 Compare December 28, 2023 12:10
@barbibulle
Copy link
Collaborator

@barbibulle I suggest we should abandon the support of RemoteLink, so that the type annotation between controller and link would be simpler.

I agree. RemoteLink served its purpose in the past, but there are easier ways to achieve the same with a slightly different topology: instead of having a local controller that can exchange data with a remote controller via a remote link relay, the alternative is to have a relay that exposes HCI interfaces over a remotable transport (TCP, WebSocket) rather than "link" interfaces. We can now use RootCanal as such a remote HCI hub.

@zxzxwu zxzxwu merged commit d8e6700 into google:main Jan 9, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants