-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete CSIP and CAP #374
Conversation
One question: LTK and LK must be retrieved asynchronously, but GATT read must be synchronous. How to resolve this? |
I have a WIP local branch that implements support for async characteristic values (both read and write). I'll polish it off and submit a PR shortly, that should solve your use case here. |
02a6274
to
90105ba
Compare
We may merge this CL first, and then create another PR when the async GATT read is ready. |
bumble/crypto.py
Outdated
|
||
|
||
# ----------------------------------------------------------------------------- | ||
def generate_random_static_address() -> bytes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this function should return an Address
, with the right address type? (Also, this is a function that uses crypto, but isn't a crypto function itself, so maybe it should live somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rand / prand is also considered crypto somehow? But yes, they're better to be classmethods of Address
. The only exception is prand - hosting it in hci/Address is not very proper, but there isn't a module more proper than crypto(from my point of view).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving address methods to #379
Also add random address generation functions.
Changes:
TODO:
Test: