Audio Stream Control Service #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
zxzxwu
force-pushed
the
ascs
branch
4 times, most recently
from
3c8d627
to
ffbaa7e
Compare
|
In run_unicast_server.py, It would be easier to use if we can pack a liblc3 interface into Python, but I am not familiar with this part. |
zxzxwu
changed the title
barbibulle
approved these changes
Dec 9, 2023
| @@ -452,6 +759,417 @@ def __init__( | |||
| super().__init__(characteristics) | |||
|
|
|||
|
|
|||
| class AseStateMachine(gatt.Characteristic): | |||
There was a problem hiding this comment.
Would it make sense to have the characteristic as a property of AseStateMachine rather than directly inheriting from gatt.Characteristic? The characteristic value (read and write) can easily be delegated to this object.
There was a problem hiding this comment.
Maybe in another PR? Currently the design can avoid ASCS main service accessing members of characteristics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #356
Status: (Sink only) Play, pause, decoding are verified.