Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avrcp #337

Merged
merged 7 commits into from
Jan 28, 2024
Merged

avrcp #337

merged 7 commits into from
Jan 28, 2024

Conversation

barbibulle
Copy link
Collaborator

AVRCP implementation.
This is still fairly basic, but enough to implement a number of Controller and Target use cases.
Still WIP, gathering comments/suggestions.

bumble/avrcp.py Outdated
event_id = pdu[0]
subclass: Any
# TODO: handle more subclasses
if event_id == EventId.PLAYBACK_STATUS_CHANGED:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dict might be better here.

@zxzxwu
Copy link
Collaborator

zxzxwu commented Jan 19, 2024

Since this PR is quite big, can we start from a fundemental part like protocol definitions?

@barbibulle
Copy link
Collaborator Author

Since this PR is quite big, can we start from a fundemental part like protocol definitions?

I apologize to the reviewers for the large PR. Unfortunately, breaking it down into smaller PRs is more work than I have the time for right now :-(

Squashed commits:
[90f2024] fix import order
[0edd321] add a few docstrings
[77a0ac0] wip
[adcf159] wip
[96cbd67] wip
[d8bfbab] wip (+1 squashed commit)
Squashed commits:
[43b4d66] wip (+2 squashed commits)
Squashed commits:
[3dafaa8] wip
[5844026] wip (+1 squashed commit)
Squashed commits:
[4cbb35a] wip (+1 squashed commit)
Squashed commits:
[4d2b6d3] wip (+4 squashed commits)
Squashed commits:
[f2da510] wip
[318c119] wip
[923b4eb] wip
[9d46365] wip

use a dict instead of a series of ifs (+6 squashed commits)
Squashed commits:
[90f2024] fix import order
[0edd321] add a few docstrings
[77a0ac0] wip
[adcf159] wip
[96cbd67] wip
[d8bfbab] wip
@barbibulle barbibulle marked this pull request as ready for review January 28, 2024 09:27
@barbibulle barbibulle merged commit dfdaa14 into main Jan 28, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants