Fix typos #270
Merged
Fix typos #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we also add Frontend checking in presubmits? |
|
Fixing #266 |
barbibulle
reviewed
Sep 7, 2023
bumble/hfp.py
Outdated
| @@ -390,7 +391,7 @@ async def execute_command( | |||
| ) | |||
| if result.code == 'OK': | |||
| if response_type == AtResponseType.SINGLE and len(responses) != 1: | |||
| raise ProtocolError("NO ANSWER") | |||
| raise InvalidStateError("NO ANSWER") | |||
There was a problem hiding this comment.
I think ProtocolError is more appropriate here. An InvalidStateError is usually more representative of a condition like trying to close a stream that's not open. a ProtocolError reflects an error in an exchange between two entities, where the syntax or sequence of messages isn't what's expected or allowed, which seems to be the case here.
There was a problem hiding this comment.
I extend BaseError to show non-digital errors.
zxzxwu
force-pushed
the
typo
branch
2 times, most recently
from
8a0b1ab
to
bca674b
Compare
barbibulle
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.