Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some commands and events in hci #206

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add some commands and events in hci #206

merged 1 commit into from
Jul 10, 2023

Conversation

benquike
Copy link
Contributor

No description provided.

bumble/hci.py Outdated
)
class HCI_Set_Connectionless_Peripheral_Broadcast_Receive_Command(HCI_Command):
'''
See Bluetooth spec @ Set Connectionless Peripheral Broadcast Receive Command
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: @ 7.1.50

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

return_parameters_fields=[
('status', STATUS_SPEC),
('bd_addr', Address.parse_address),
],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing lt_addr

Copy link
Contributor Author

@benquike benquike Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

bumble/hci.py Outdated
@HCI_Command.command(
fields=[
('bd_addr', Address.parse_address),
('sync_timeout', 2),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spec, this is called sync_scan_timeout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@benquike benquike requested a review from barbibulle June 29, 2023 07:47
@barbibulle barbibulle merged commit 532b99f into google:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants