-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some commands and events in hci #206
Conversation
bumble/hci.py
Outdated
) | ||
class HCI_Set_Connectionless_Peripheral_Broadcast_Receive_Command(HCI_Command): | ||
''' | ||
See Bluetooth spec @ Set Connectionless Peripheral Broadcast Receive Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: @ 7.1.50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
return_parameters_fields=[ | ||
('status', STATUS_SPEC), | ||
('bd_addr', Address.parse_address), | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is missing lt_addr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
bumble/hci.py
Outdated
@HCI_Command.command( | ||
fields=[ | ||
('bd_addr', Address.parse_address), | ||
('sync_timeout', 2), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the spec, this is called sync_scan_timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
No description provided.