realtek driver #203
Merged
realtek driver #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uael
approved these changes
Jun 20, 2023
| host.send_hci_packet(HCI_RTK_Drop_Firmware_Command()) | ||
|
|
||
| # Wait for the command to be effective (no response is sent) | ||
| await asyncio.sleep(Driver.POST_DROP_DELAY) |
There was a problem hiding this comment.
nit: perform a reset instead ?
There was a problem hiding this comment.
I'm concerned that performing a reset instead of waiting may lead to a deadlock, because if the reset command is sent while the dongle FW is restarting, it may be dropped, and we'd be waiting for a response for ever.
There was a problem hiding this comment.
I've just realized it's only used for the command line tool so I guess it's fine!
Squashed commits: [d29a350] wip [7f541ed] wip [1e2902e] basic working version [14b497a] wip
barbibulle
force-pushed
the
gbg/realtek-driver
branch
from
cb718ab
to
696a8d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for loading FW images and config on Realtek USB dongles