Move from pkg:pedantic to pkg:dart_flutter_team_lints

[kevmoo]

No description provided.

[davidmorgan]

Thanks!

Hmmmm there are some lint errors.

Looking at the lint set, I'm not super convinced ... ones that look worth fixing:

avoid_function_literals_in_foreach_calls
directives_ordering
unnecessary_lambdas
unnecessary_parenthesis
use_super_parameters

Problematic:

avoid_catching_errors ... is just wrong, sometimes you have to catch errors and this pushes people to do the wrong thing
prefer_const_constructors ... is a flutterism
prefer_relative_imports ... consistency here would be good but I'm not aware of a style push?
avoid_dynamic_calls, return_of_invalid_type, for_in_of_invalid_type, map_type_not_assignable, inference_failure_on_untyped_parameter ... these all relate to strict inference and will force changes to the code, are we sure those are equivalent?
lines_longer_than_80_chars ... I seem to remember this has false positives, maybe it doesn't any more
use_is_even_rather_than_modulo ... does not seem worth it

I didn't check for lints that are not enabled after the switch from pedantic.

Not really sure where to go with this, any suggestions? :)

[kevmoo]

More that pedantic is DEAD and trying to move away from it.

…

On Tue, May 7, 2024 at 12:43 AM David Morgan ***@***.***> wrote: Thanks! Hmmmm there are some lint errors. Looking at the lint set, I'm not super convinced ... ones that look worth fixing: avoid_function_literals_in_foreach_calls directives_ordering unnecessary_lambdas unnecessary_parenthesis use_super_parameters Problematic: avoid_catching_errors ... is just wrong, sometimes you have to catch errors and this pushes people to do the wrong thing prefer_const_constructors ... is a flutterism prefer_relative_imports ... consistency here would be good but I'm not aware of a style push? avoid_dynamic_calls, return_of_invalid_type, for_in_of_invalid_type, map_type_not_assignable, inference_failure_on_untyped_parameter ... these all relate to strict inference and will force changes to the code, are we sure those are equivalent? lines_longer_than_80_chars ... I seem to remember this has false positives, maybe it doesn't any more use_is_even_rather_than_modulo ... does not seem worth it I didn't check for lints that are *not* enabled after the switch from pedantic. Not really sure where to go with this, any suggestions? :) — Reply to this email directly, view it on GitHub <#1314 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEFCVHDP633ZANUMA3ZJTZBCA25AVCNFSM6AAAAABHJRWPGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGY2TOMRXGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dave26199]

It might be dead but it hasn't stopped moving yet ;) with over 2000 users on pub.

I agree it'd be good to move off, do we need a script that diffs the lint set, then switches to a new base with the diff undone on top of it so it's a no-op?

[kevmoo]

I think we'd have to bump the min SDK on build_value first. 2.12 is a LOW base!

…

On Tue, May 7, 2024 at 9:44 AM David Morgan ***@***.***> wrote: It might be dead but it hasn't stopped moving yet ;) with over 2000 users on pub. I agree it'd be good to move off, do we need a script that diffs the lint set, then switches to a new base with the diff undone on top of it so it's a no-op? — Reply to this email directly, view it on GitHub <#1314 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEFCVSCTDNO4NWOQ2QUELZBEAH5AVCNFSM6AAAAABHJRWPGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYHA4DGMRXHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>