[python] Use BrotliDecompress() #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
pushed a commit
to anthrotype/brotli
that referenced
this pull request
Mar 15, 2015
anthrotype
pushed a commit
to anthrotype/brotli
that referenced
this pull request
Mar 16, 2015
So that we can use a callback to dynamically allocate the decompression buffer, getting rid of the optional bufsize argument to decompress.decompress().
| int output_callback(void* data, const uint8_t* buf, size_t count) { | ||
| std::vector<uint8_t> *output = (std::vector<uint8_t> *)data; | ||
| output->insert(output->end(), buf, buf + count); | ||
| } |
There was a problem hiding this comment.
As anthrotype@ pointed out, please add a return statement.
szabadka
added a commit
that referenced
this pull request
Mar 16, 2015
[python] Use BrotliDecompress()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can use a callback to dynamically allocate the decompression
buffer, getting rid of the optional bufsize argument to
decompress.decompress().