Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further fixes to allow compilation on MS Visual Studio 2010 #32

Closed
wants to merge 4 commits into from

Conversation

anthrotype
Copy link
Member

Hello,

I don't like playing the Windows guy here, but there are still some unresolved issues with Microsoft's C++ compiler.

The recent patches by @szabadka ensured the Brotli encoder compiles successfully when using MS Visual Studio 2013.
However, the problem is that the latest Python for Windows (versions 3.3 and 3.4) are compiled with Visual Studio 2010.
Now, from what I understood, there's a requirement that Python extensions be linked to the same C runtime library which Python itself uses:

https://docs.python.org/3.4/extending/windows.html

If that's the case, then we must define a log2 (binary logarithm) function, which unfortunately is not present in math.h from Visual C++ 2010.
Here's my attempt, which seemingly doesn't break anything else, since I only redefine log2 if _MSC_VER <= 1600.

Through this patch, the Python extension can be built on Windows using the same compiler version used to build CPython itself.
Well, at least for Python 3.3 and 3.4... previous versions are still built with Visual Studio 2008, but I still had no luck with that.

Cheers,

C.

@anthrotype
Copy link
Member Author

#33 fixes this so I shall close it.
thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant