Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Dartify all the C++ styled code #17

Open
wants to merge 76 commits into
base: master
Choose a base branch
from

Conversation

spydon
Copy link

@spydon spydon commented Jun 15, 2020

The code is written in a very C++ way, this is the first iteration of making it more according to the dart style guide.

Since nobody seems to maintain this repository we have a maintained refactored version over here:
https://github.com/flame-engine/forge2d

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@spydon
Copy link
Author

spydon commented Jun 15, 2020

@googlebot I signed it!

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tfoel and others added 2 commits August 27, 2020 21:41
Avoid shadowing the fixture's own 'p' position by the incoming parameter.
Fix hit test bug for circle shapes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants