-
Notifications
You must be signed in to change notification settings - Fork 36
Dartify all the C++ styled code #17
base: master
Are you sure you want to change the base?
Conversation
Fixes for dart 2
added getVertexCount chain shape
Expose vertices information for ChainShape
Another bad assert in transform removed
Remove 'new' keyword
Remove C++ type function calls for viewport
fixing warnings and formatting
Fixing comments to new format
Fix torque bug
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Avoid shadowing the fixture's own 'p' position by the incoming parameter.
Fix hit test bug for circle shapes
a29be6a
to
df65d19
Compare
c2ac0bb
to
613f507
Compare
The code is written in a very C++ way, this is the first iteration of making it more according to the dart style guide.
Since nobody seems to maintain this repository we have a maintained refactored version over here:
https://github.com/flame-engine/forge2d