Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Fix strong mode error in buffer_utils.sort #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yourpalal
Copy link

Fix strong mode error in buffer_utils.sort. Once temp is made, the type information is lost and setRange fails type checks.

You can see this error by running

pub serve --web-compiler dartdevc example

and going to http://localhost:8080/?demo=box_test

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@yourpalal
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@feroult
Copy link

feroult commented Jul 15, 2018

Hi!

No merges so far... Any plans?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants