Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add block factory export in json #8051

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

maribethb
Copy link
Contributor

The basics

The details

Resolves

Needed for google/blockly-samples#2291

Proposed Changes

Adds an "Export Block Library" button that downloads the block factory blocks in JSON format.

Reason for Changes

  • This is needed to support uploading blocks to the new tool.
  • Unfortunately I had to add a new button because using XML won't work. The block definitions used in this tool are not directly compatible with the ones in the new tool. Adjusting the JSON by hand to make them load-able in the new tool is 1000% easier than adjusting the XML by hand.
  • I will add documentation explaining how to get blocks from one tool into the other.
  • See also feat: support uploading file from old block factory blockly-samples#2336 for how this file is used

Test Coverage

Documentation

Coming soon!

Additional Information

@maribethb maribethb requested a review from a team as a code owner April 24, 2024 17:40
@github-actions github-actions bot added the PR: feature Adds a feature label Apr 24, 2024
@maribethb maribethb merged commit da97e78 into google:develop Apr 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants