Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to copy and paste workspace comments #8024

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes #8008

Proposed Changes

Integrates the new RenderedWorkspaceComment with the copy paste system.

Test Coverage

Manually tested that copying and pasting works properly. Including with text, collapsed comments, resized comments, etc.

Documentation

N/A

Additional Information

N/A

@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature labels Apr 11, 2024
@BeksOmega BeksOmega marked this pull request as ready for review April 11, 2024 20:19
@BeksOmega BeksOmega requested a review from a team as a code owner April 11, 2024 20:19
@BeksOmega BeksOmega requested review from gonfunko and removed request for rachel-fenichel April 12, 2024 17:16
@BeksOmega
Copy link
Collaborator Author

BeksOmega commented Apr 12, 2024

@gonfunko This isn't blocking the beta release on Monday so don't stress if you're busy today. But I am planning to build on top of this code.

[Edit: also looks like I need to rebase]

@BeksOmega BeksOmega merged commit dabb11f into google:rc/v11.0.0 Apr 15, 2024
6 checks passed
@BeksOmega BeksOmega changed the title feat!: add ability to copy and paste workspace comments feat: add ability to copy and paste workspace comments Apr 19, 2024
@BeksOmega BeksOmega removed the breaking change Used to mark a PR or issue that changes our public APIs. label Apr 19, 2024
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants