Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes comments being positioning incorrectly when loading from XML in RTL mode
Proposed Changes + Reasons
Makes it so that comments are positioned relative to the toolbox when loading in RTL mode, to match blocks.
To get this to work the same as blocks I had to change how I was handling RTL in the comment view. We can't apply the scale at the top level because that messes up the transform (we still want +x to go right and +y to go down in RTL mode to match blocks). So I need to apply it to the sub elements of the icon. And to get rotating the foldout icon to work, that meant I needed an element to encompass the elements of the top bar.
Test Coverage
Manually tested loading and saving in RLT and LTR in JSON and XML
Documentation
N/A
Additional Information
N/A