-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make grid options togglable #7828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the issue:
This will mean that the state of the workspace could get out of sync with its inject options, but I don't think that's worth fixing.
Is this mooting the idea of modifying the properties of the GridOptions
object? I'm not sure that would even be desirable let alone "worth fixing".
Yesh not doing that. |
* fix: destroy connection highlight when the connection is disposed (#7830) * fix: fix reference docs toc generation (#7832) * fix: insertion marker previewer finding wrong connection for different conn counts (#7833) * feat: make grid options togglable (#7828) * chore(deps): Bump prettier from 3.1.1 to 3.2.5 (#7831) Bumps [prettier](https://github.com/prettier/prettier) from 3.1.1 to 3.2.5. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.1.1...3.2.5) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: disposing of connection previewer (#7834) * fix: typo in Click event class docs * chore: rollup of updates from translatewiki for 10.4.0 (#7856) * chore: update metadata for v10.4.0 (#7857) * release: update version number to 10.4.0 * fix: connection previewer disposing too early * Merge pull request #7859 from BeksOmega/fix/previewer-disposing fix: connection previewer disposing too early (cherry picked from commit da3ec25) * release: update version number to 10.4.1 * chore: move connection previewer out of subfolder (#7835) * chore(deps-dev): Bump undici from 5.26.3 to 5.28.3 (#7862) Bumps [undici](https://github.com/nodejs/undici) from 5.26.3 to 5.28.3. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.26.3...v5.28.3) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update webdriverio to fix chrome endpoint issue (#7875) * fix: insertion marker drag scaling (#7874) * fix: insertion marker drag scaling * chore: added docs for other params * fix: restore respecting snap radius (#7873) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Maribeth Bottorff <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elvis Adomnica <[email protected]> Co-authored-by: Rachel Fenichel <[email protected]>
The basics
The details
Resolves
Fixes #7827
Proposed Changes + Reasons
Makes it so that grid options are toggleable so App Inventor can toggle them from their context menu items.
Test Coverage
Manually tested that setting all of the options works as expected.
Documentation
Covered by reference documentation.
Additional Information
N/A