-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Renable macos-latest build #7640
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
c09a145
to
5d51fee
Compare
d420bc3
to
c2d6da0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised that the mocha tests just seem to work now without having done any work? But I'm willing to just try this and see if it breaks later.
@cpcallen do you know of anything that may have changed related to mocha tests running? you were the last one poking this I think
WIll go ahead and submit this but still curious to hear from @cpcallen if he is aware of anything related to build that may have changed on macos since he last poked this. |
The basics
The details
Resolves
Fixes #2114
Proposed Changes
Re-enables build for macosx
build seems to work fine after several triggers: https://github.com/alicialics/blockly/actions/runs/6830695852
Re-enables browsers-test for ubuntu
browsers-test seem to fail but this is a manually triggered job that doesn't get run very often:
https://github.com/alicialics/blockly/actions/runs/6830698569
Reason for Changes
#2114
Test Coverage
ran in CI
Documentation
N/A
Additional Information
cc @BeksOmega