Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Renable macos-latest build #7640

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

alicialics
Copy link
Contributor

@alicialics alicialics commented Nov 10, 2023

The basics

The details

Resolves

Fixes #2114

Proposed Changes

Re-enables build for macosx

build seems to work fine after several triggers: https://github.com/alicialics/blockly/actions/runs/6830695852

Re-enables browsers-test for ubuntu

browsers-test seem to fail but this is a manually triggered job that doesn't get run very often:
https://github.com/alicialics/blockly/actions/runs/6830698569

Reason for Changes

#2114

Test Coverage

ran in CI

Documentation

N/A

Additional Information

cc @BeksOmega

@alicialics alicialics requested a review from a team as a code owner November 10, 2023 23:02
@alicialics alicialics marked this pull request as draft November 10, 2023 23:02
Copy link

conventional-commit-lint-gcf bot commented Nov 10, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Nov 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@alicialics alicialics force-pushed the fix_macos_tests branch 2 times, most recently from c09a145 to 5d51fee Compare November 10, 2023 23:28
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Nov 11, 2023
@alicialics alicialics marked this pull request as ready for review November 11, 2023 00:03
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised that the mocha tests just seem to work now without having done any work? But I'm willing to just try this and see if it breaks later.

@cpcallen do you know of anything that may have changed related to mocha tests running? you were the last one poking this I think

@maribethb
Copy link
Contributor

WIll go ahead and submit this but still curious to hear from @cpcallen if he is aware of anything related to build that may have changed on macos since he last poked this.

@maribethb maribethb merged commit 3d3cd3f into google:develop Nov 29, 2023
9 checks passed
maribethb added a commit that referenced this pull request Dec 4, 2023
maribethb added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug and reenable macOS CI on GitHub Actions
2 participants