-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update setShadow TSDoc for Block and BlockSvg #7639
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
Sweet thank you for the fix! Just one thing before merging: Can you change the docs to line wrap at column 80? I'm surprised the linter didn't catch this, @maribethb as a heads up. |
I forgot the space at the end of the line, and Prettier didn't like that, haha! Just fixed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, this looks perfect thank you so much!
The linter no longer cares about line length; it's prettier's job to care about that. running the formatter should autofix this. |
Even when I did run Prettier on the files, it didn't catch my line length issue. Not sure if I did something incorrectly, but I made sure it was using the prettier config. I just checked, and it looks like prettier actually doesn't do line wrapping for comments. it's an open issue on Prettier prettier/prettier#265 |
The basics
The details
Resolves
Fixes #7636
Proposed Changes
Updates TSDocs for
setShadow
according to issue.Reason for Changes
Test Coverage
Documentation
Additional Information