Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update setShadow TSDoc for Block and BlockSvg #7639

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

systemc12ashe
Copy link
Contributor

The basics

The details

Resolves

Fixes #7636

Proposed Changes

Updates TSDocs for setShadow according to issue.

Reason for Changes

Test Coverage

Documentation

Additional Information

Copy link

google-cla bot commented Nov 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the PR: fix Fixes a bug label Nov 10, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega assigned BeksOmega and unassigned maribethb Nov 10, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for maribethb November 10, 2023 16:48
@BeksOmega
Copy link
Collaborator

Sweet thank you for the fix! Just one thing before merging: Can you change the docs to line wrap at column 80?

I'm surprised the linter didn't catch this, @maribethb as a heads up.

@systemc12ashe
Copy link
Contributor Author

I forgot the space at the end of the line, and Prettier didn't like that, haha! Just fixed that.

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this looks perfect thank you so much!

@BeksOmega BeksOmega merged commit a2b895f into google:develop Nov 10, 2023
6 checks passed
@maribethb
Copy link
Contributor

I'm surprised the linter didn't catch this,

The linter no longer cares about line length; it's prettier's job to care about that. running the formatter should autofix this.

@systemc12ashe
Copy link
Contributor Author

systemc12ashe commented Nov 10, 2023

The linter no longer cares about line length; it's prettier's job to care about that. running the formatter should autofix this.

Even when I did run Prettier on the files, it didn't catch my line length issue. Not sure if I did something incorrectly, but I made sure it was using the prettier config. I just checked, and it looks like prettier actually doesn't do line wrapping for comments. it's an open issue on Prettier prettier/prettier#265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update setShadow TSDoc for Block and BlockSvg
3 participants