Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shadow block dropdown gets color of parent category #7628

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Apoorvgarg-creator
Copy link
Contributor

The basics

The details

Resolves

Fixes #7416

Proposed Changes

The block doesn't check its parent colour even if it's a shadow block for the dropdown field, It simply takes the colour style from the block itself.

Reason for Changes

Test Coverage

Documentation

Additional Information

@Apoorvgarg-creator Apoorvgarg-creator requested a review from a team as a code owner November 2, 2023 11:26
@github-actions github-actions bot added the PR: fix Fixes a bug label Nov 2, 2023
@BeksOmega BeksOmega assigned BeksOmega and unassigned maribethb Nov 2, 2023
@BeksOmega BeksOmega requested review from BeksOmega and removed request for maribethb November 2, 2023 14:56
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you for your work on this :D

I'll give this a manual test and then get this merged!

@BeksOmega BeksOmega merged commit 9d11767 into google:develop Nov 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow block dropdown gets color of parent category
3 participants