feat: add tooltip support for icons #7608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7047
Proposed Changes
Makes it so that built-in icons can have tooltips.
Reason for Changes
People want icons to have tooltips.
Test Coverage
Manually tested that by default icons show the tooltip of the parent.
Manually tested that setting the tooltip displays the new tooltip.
Manually tested that setting the new tooltip to
nulldisplays the tooltip of the parent.Documentation
This should be added to the custom icons docs maybe? Need to check.
Additional Information
This adds tooltip support for any icons inheriting from
Blockly.icons.Icon. Any icons made by external developers which are not inheriting can do what I've done here to support their own tooltips.