Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text join block warning when using block-plus-minus plugin #7598

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: text join block warning when using block-plus-minus plugin #7598

merged 1 commit into from
Oct 20, 2023

Conversation

HadyBazzi
Copy link
Contributor

@HadyBazzi HadyBazzi commented Oct 19, 2023

The basics

The details

Resolves

When combined with google/blockly-samples#2025 this resolves google/blockly-samples#1134.

Proposed Changes

Register the quote_image_mixin.

Reason for Changes

This allows the block-plus-minus plugin to access the mixin which stops the following warning (when combined with google/blockly-samples#2025) from appearing when using the text_join block with the plugin:
field named "TEXT" not found in "text_join" block

Additional Information

The passing of this should be followed by the passing of google/blockly-samples#2025.

@HadyBazzi HadyBazzi requested a review from a team as a code owner October 19, 2023 19:47
@google-cla
Copy link

google-cla bot commented Oct 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for rachel-fenichel October 20, 2023 16:30
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for the fix!

@BeksOmega BeksOmega merged commit c8cc33a into google:develop Oct 20, 2023
13 checks passed
@HadyBazzi HadyBazzi deleted the fix/text-join-block-warning-when-using-block-plus-minus-plugin branch October 20, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block-plus-minus plugin: field named "TEXT" not found in "text_join" block
3 participants