fix: colour from colour picker not being updated #7584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested review from
maribethb
and removed request for
rachel-fenichel
maribethb
approved these changes
Oct 9, 2023
BeksOmega
added a commit
that referenced
this pull request
Oct 9, 2023
* fix: colour from colour picker not being updated * chore: clarify what code is doing
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7582
Proposed Changes
Makes it so picking a colour actually updates the colour field.
Reason for Changes
Bugs be bad.
Test Coverage
Manually tested selecting colors in geras and zelos. Manually tested adding and removing fields in zelos switches between full block and normal colour fields.
Documentation
N/A
Additional Information
N/A