fix: color field sizing being incorrect #7566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Oct 2, 2023
rachel-fenichel
pushed a commit
that referenced
this pull request
Oct 2, 2023
(cherry picked from commit 5151b28)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7562
Proposed Changes
Makes it so the color field size is correct in geras.
Reason for Changes
Color field got wider with release v10.2.0
Test Coverage
Tested that geras sizing matches v10.1.2, and zelos sizing matches v10.2.0 Tested zelos sizing with full block fields and non-full-block fields.
Documentation
N/A
Additional Information
This should be patched.
The zelos non-full-block field is now a pixel taller, but I think it's better to conform to the grid than make it 31 pixels tall.