fix: style attribute for xml in ws factory #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes broken workspace factory
Proposed Changes
Reverts changes in #7503 to the workspace factory that broke it
Reason for Changes
The JavaScript class
Elementdoesn't have astyleproperty. OnlyHTMLElements have astyleproperty that can be set directly via JS.<xml>elements in the DOM do have astyleattribute, so we can set the attribute using thesetAttributeAPI. This makes the CSP unhappy, but not really sure how to prevent that since there is nostyleproperty. Since this code is outside the library, we won't be breaking the CSP for anyone using blockly. Just on our own hosted demos site.The dev-tools code will be removed soon.
Test Coverage
tested manually
Documentation
Additional Information