fix(build): Fix broken npm install of Closure Compiler #7547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this expected to only have changes to the package lock? |
Yes, for some reason this was deleted in #7500 and these specific changes to package lock are what caused closure compiler to stop working on macos. Hoping they weren't deleted just because npm decided we didn't need them on a linux machine. |
maribethb
approved these changes
Sep 27, 2023
rachel-fenichel
pushed a commit
to rachel-fenichel/blockly
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes broken build due to missing
goog-closure-compilerdependencies.Proposed Changes
Install
google-closure-compiler-osxor …-windowsas appropriate.Reason for Changes
Not having a broken build is good.
Test Coverage
I ran
npm run buildand it succeeded. What more do you want?!?