feat: add getVariableName and getProcedureName to CodeGenerator #7445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #6008 and works on #7326
Proposed Changes
getVariableName
andgetProcedureName
APIs toCodeGenerator
class.nameDB_
public to account for use cases not served by the above APIs.nameDB_
directly.for...of
instead of funky for loop; this improves the typing information (while these files are not in TS yet, editors are still able to use the TS information for better autosuggest)Behavior Before Change
The only way to get these, which you need to do inside block-code generator functions, was to access the (previously protected)
nameDB_
object.Behavior After Change
nameDB_
. The advantage of these methods is that it prints a warning ifnameDB_
has not been initialized, which is a common failure mode we've seen in the forums.nameDB_
directly.Reason for Changes
Improved developer APIs and documentation
Test Coverage
Added some basic unit tests. The
Names
db functionality has its own tests, so just stubbed that out.Documentation
Beka currently has a doc in progress that would touch this
cc @BeksOmega
Additional Information