chore: update PR template and add info for new contribs #7405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Proposed Changes
Reason for Changes
I don't like checking all the boxes, and our team makes the overwhelming majority of PRs. So I prioritized streamlining PR creation, while still trying to provide helpful information to new contributors. Let me know if you think I didn't hit the right balance though.
Documentation
Note: I also updated the style guide and sent a CL to Rachel for review.
Additional Information
I also wrote another GitHub workflow that would simply add a comment if a PR is against master and not develop. I thought this might be useful because I feel like it can be easy to miss which branch is selected for a PR due to it being in small type at the top. I don't always remember to check. I decided against including it here since develop is the default branch, but I can do so if you think it would be useful. It's a really small/straightforward workflow.