Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: have the trashcan hide scrollbars when the flyout opens #7357

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A
Related to google/blockly-samples#1841

Proposed Changes

Temporarily hide the scrollbars in the main workspace while the trashcan flyout is open.

Reason for Changes

Having multiple sets of overlapping scrollbars is confusing to users.

Test Coverage

Manually tested that scrollbars are hidden.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner August 3, 2023 20:30
@github-actions github-actions bot added the PR: feature Adds a feature label Aug 3, 2023
@BeksOmega BeksOmega merged commit 2ac13b5 into google:develop Aug 4, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants