feat: add the ability to toggle scrollbar visibility #7314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Fixes #6971
Proposed Changes
Adds a method to toggle the visibility of a scrollbar pair.
Reason for Changes
App inventor needs this to reduce clutter when opening flyouts.
Test Coverage
Manually tested that setting the scrollbar visibility hides the scrollbars.
Documentation
N/A
Additional Information
I thought about solving this in a bunch of different ways, but the only one that ended up working was adding the internal
setVisible
method.Removing the
this.pair
check alone doesn't work because external devs can access the individual scrollbars and try to mess with them, so we will run into the corner-error that the comment references. And we can't fix that by by telling the scrollbar pair to update itself when an individual scrollbar gets hidden, because having a reference to the scrollbar pair would cause circular dependencies.