Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to toggle scrollbar visibility #7314

Merged

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6971

Proposed Changes

Adds a method to toggle the visibility of a scrollbar pair.

Reason for Changes

App inventor needs this to reduce clutter when opening flyouts.

Test Coverage

Manually tested that setting the scrollbar visibility hides the scrollbars.

Documentation

N/A

Additional Information

I thought about solving this in a bunch of different ways, but the only one that ended up working was adding the internal setVisible method.

Removing the this.pair check alone doesn't work because external devs can access the individual scrollbars and try to mess with them, so we will run into the corner-error that the comment references. And we can't fix that by by telling the scrollbar pair to update itself when an individual scrollbar gets hidden, because having a reference to the scrollbar pair would cause circular dependencies.

@BeksOmega BeksOmega requested a review from a team as a code owner July 20, 2023 21:45
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 20, 2023
@BeksOmega BeksOmega merged commit c3aa970 into google:develop Jul 28, 2023
10 checks passed
@BeksOmega BeksOmega deleted the feat/toggle-scrollbar-visibility branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visually hide scrollbars temporarily
2 participants