Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitattributes file to standardize line endings #7191

Closed
1 task done
maribethb opened this issue Jun 21, 2023 · 6 comments · Fixed by #7517
Closed
1 task done

Add gitattributes file to standardize line endings #7191

maribethb opened this issue Jun 21, 2023 · 6 comments · Fixed by #7517
Assignees
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days

Comments

@maribethb
Copy link
Contributor

maribethb commented Jun 21, 2023

🚧⚠️🚧 This issue is being saved for Grace Hopper Open Source Day. 🚧⚠️🚧 An event we're running to help girls and non-binary technologists make their first contributions to open source! Please see our list of help wanted issues if you'd like to contribute!


Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

If you change files when working on Windows, you will end up checking in files with Windows-style CRLF line endings, but the library should use Linux-style LF endings.

To rectify this, we should add a .gitattributes file with the following content:

* text=auto

This will have Git automatically convert the line endings in any text-based file (so not binary files like images) to LF when checking them out, but allow you to use CRLF endings on your local copy if you're using Windows.

h/t this article for the info

@maribethb maribethb added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member good first issue labels Jun 21, 2023
@mehboobali98
Copy link

Hi, can I work on this? TIA

@1mazin
Copy link

1mazin commented Jun 21, 2023

@maribethb can I work on this issue?

@maribethb
Copy link
Contributor Author

Hi @mehboobali98 you got here first, go for it! We have information about contributing on our site. One important thing it to make sure your commit messages are formatted appropriately. Thanks!

@1mazin Someone else asked first but will let you know if they decide to drop the issue. You might find other issues you want to work on by checking the size: small label, or check the good first issue tag in our sister repo google/blockly-samples

Thanks!

@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label Jun 28, 2023
@BeksOmega BeksOmega added the ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ label Sep 5, 2023
@BeksOmega BeksOmega added the size: small Bugs that can be picked up and completed in 1-3 days label Sep 5, 2023
@sam301100
Copy link
Contributor

Hello @maribethb,
Can I work on this issue?

@BeksOmega
Copy link
Collaborator

@sam301100 Go for it!

@sam301100
Copy link
Contributor

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Projects
No open projects
Status: Done Testing
Development

Successfully merging a pull request may close this issue.

5 participants