fix: insertion markers destroying procedure models for block-shareable-procedures in v11 #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Jan 29, 2024
BeksOmega
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
Found that with the new v11 beta the insertion marker managers for procedure definitions were destroying the procedure models when they are destroyed. This is because insertion markers now do the non-full erialization (since they should just reference the model of whatever block they're shadowing).
Reason for Changes
Fix buggies. This was causing mirroring events into other workspaces to break.
Test Coverage
Manually tested. Confirmed that tests pass.
Documentation
I'll update the description of google/blockly#7730 to reflect this break as well.
Additional Information
N/A