Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Permits css capabilities for minimap #1860

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

cesarades
Copy link
Contributor

Description
The minimap workspace inherits the theme of the primary workspace. Now, however, developers can also edit the minimap with CSS. Namely the wrapper for the minimap (like the box shadow) and the focus region (the fill color).

@cesarades cesarades requested a review from a team as a code owner August 15, 2023 21:29
Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two little nits about class names =)

plugins/workspace-minimap/src/minimap.ts Outdated Show resolved Hide resolved
plugins/workspace-minimap/src/focus_region.ts Outdated Show resolved Hide resolved
@cesarades cesarades merged commit f8cbacf into google:master Aug 15, 2023
7 checks passed
@cesarades cesarades deleted the minimapTheme branch August 15, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants