Wasm source maps #387
Wasm source maps #387
Conversation
src/webassembly.cc
Outdated
| uint32_t size = ReadVarUInt32(§ion.contents); | ||
| string_view source_mapping_url = | ||
| ReadPiece(size, §ion.contents); | ||
| id.resize(size); |
There was a problem hiding this comment.
I think this would be simpler and safer to write as id.assign(source_mapping_url).
|
Hi. Wanted to quickly check if there is additional work needed for PR or if it is ready to go? |
| @@ -2166,6 +2196,8 @@ bool DoParseOptions(bool skip_unknown, int* argc, char** argv[], | |||
| } | |||
| } else if (args.TryParseOption("--source-filter", &option)) { | |||
| options->set_source_filter(std::string(option)); | |||
| } else if (args.TryParseOption("--source-map", &option)) { | |||
There was a problem hiding this comment.
Please add documentation for this flag to the usage string and into the user guide.
There was a problem hiding this comment.
Done - added usage notes to using.md and added the option to the usage string
| @@ -0,0 +1,30 @@ | |||
| # RUN: %yaml2obj %s -o %t.obj | |||
There was a problem hiding this comment.
Thanks so much for adding yaml2obj tests. Could we add one for diff mode, so we can test our design for distinguishing between different versions of the same file?
There was a problem hiding this comment.
Thanks. I think the simplest way to do this would be to make a copy of the Wasm binary generated by yaml2obj, then create 2 different source maps for each of these. Made the change. PTAL
Add support for "inlines" and "compileunits" sources for Wasm using source maps.
Adds a new option "--source-map" which can be specified to map a URL to source map file:
--source-map=http://myurl/output.wasm.map=output.wasm.mapThe source map URL is found in the Wasm binary in the
sourceMappingURLsection.We also support specifying the source map by file name, which is useful for specifying multiple source maps in diff mode where the
sourceMappingURLmight be identical between the binaries.--source-map=path/to/output.wasm=output.wasm.map