Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOTAL row and % column output in diff mode #363

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

pepsiman
Copy link
Contributor

Fixes #361 and #335.

Before:

    FILE SIZE        VM SIZE
 --------------  --------------
  +203% +1.46Ki  [ = ]       0    [Unmapped]
  +100%     +48  +100%     +48    .rodata
  +100%      -8  +100%      -8    .ARM.exidx
   +50%      -8   +50%      -8    .fini
  +100%     -12  +100%     -12    .ARM.extab
   +99% -5.48Ki   +99% -5.48Ki    .text
  +100% +1.72Mi  +100% +1.72Mi    TOTAL

After:

    FILE SIZE        VM SIZE
 --------------  --------------
  +103% +1.46Ki  [ = ]       0    [Unmapped]
  +0.0%     +48  +0.0%     +48    .rodata
  -0.0%      -8  -0.0%      -8    .ARM.exidx
 -50.0%      -8 -50.0%      -8    .fini
  -0.0%     -12  -0.0%     -12    .ARM.extab
  -0.5% -5.48Ki  -0.5% -5.48Ki    .text
  -0.2% -4.00Ki  -0.3% -5.46Ki    TOTAL

@google-cla
Copy link

google-cla bot commented Sep 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Fixes google#361 and google#335.

Before:
    FILE SIZE        VM SIZE
 --------------  --------------
  +203% +1.46Ki  [ = ]       0    [Unmapped]
  +100%     +48  +100%     +48    .rodata
  +100%      -8  +100%      -8    .ARM.exidx
   +50%      -8   +50%      -8    .fini
  +100%     -12  +100%     -12    .ARM.extab
   +99% -5.48Ki   +99% -5.48Ki    .text
  +100% +1.72Mi  +100% +1.72Mi    TOTAL

After:
    FILE SIZE        VM SIZE
 --------------  --------------
  +103% +1.46Ki  [ = ]       0    [Unmapped]
  +0.0%     +48  +0.0%     +48    .rodata
  -0.0%      -8  -0.0%      -8    .ARM.exidx
 -50.0%      -8 -50.0%      -8    .fini
  -0.0%     -12  -0.0%     -12    .ARM.extab
  -0.5% -5.48Ki  -0.5% -5.48Ki    .text
  -0.2% -4.00Ki  -0.3% -5.46Ki    TOTAL
@haberman haberman merged commit 8be8b44 into google:main Oct 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size diff broken after PR #313 "Preserve Size Information During Diff"
2 participants