Simplify base64.cpp and fix 0 byte ending issue #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses `EVP_EncodedLength` to avoid a local implementation, and uses `EVP_DecodeBase64` to handle a corner case around null bytes at the end of input data for base64 encoding. Counterpart to https://android-review.googlesource.com/c/device/google/cuttlefish/+/3481535 Bug: b/395180112 Test: bazel test :utils_test
jemoreira
approved these changes
Feb 8, 2025
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
EVP_EncodedLengthto avoid a local implementation, and usesEVP_DecodeBase64to handle a corner case around null bytes at the end of input data for base64 encoding.Counterpart to https://android-review.googlesource.com/c/device/google/cuttlefish/+/3481535
Bug: b/395180112
Test: bazel test :utils_test