Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InstanceManager intermediate for CreationAnalyzer #873

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Remove InstanceManager intermediate for CreationAnalyzer #873

merged 1 commit into from
Jan 31, 2025

Conversation

Databean
Copy link
Member

Now cvd/cli/commands/create.cpp can create CreationAnalyzer directly.

Bug: b/392949844
Test: bazel test '//...'

@Databean
Remove InstanceManager intermediate for CreationAnalyzer
865db8c 
Now `cvd/cli/commands/create.cpp` can create `CreationAnalyzer`
directly.

Bug: b/392949844
Test: bazel test '//...'
@Databean
Copy link
Member Author

Thanks for reviewing!

@Databean Databean added this pull request to the merge queue Jan 31, 2025
Merged via the queue into google:main with commit a4edaef Jan 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemoreira jemoreira jemoreira approved these changes

@rmuthiah rmuthiah Awaiting requested review from rmuthiah rmuthiah is a code owner

@ser-io ser-io Awaiting requested review from ser-io ser-io is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Databean @jemoreira