-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retries failed go get requests. #229
Conversation
# Temporary solution until https://github.com/golang/go/issues/28194 is fixed | ||
# in order to retry failed fetch requests. | ||
# GOPROXY fallback was added in Go 1.15 | ||
export GOPROXY="proxy.golang.org|proxy.golang.org|direct" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we be worried about go 1.14?
The other branch of the if
is for go 1.13, but the functionality you're using here is for 1.15+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the logic, now based on the output of go version
Temporary solution until golang/go#28194 is fixed in order to retry failed fetch requests.
With this fix, it seems that still get go request failed. Or am missing something here? |
it seems you got Go installed, which is what this change was for, as you were able to run the tests. what's happening here is that some unit tests are failing in your environment. I sent out #499 to improve the error messages in these tests, once the PR is merged feel free to send us the errors again for better triaging. Thanks. |
Thanks for your quick reply. After updating the code, got "operation timeout" error. Does it means it's my network issue? If so, what address does it try to access?
|
I also changed go version to 1.13.8, seems that has the same issue. please help to check it when you have time.
.npm/_logs/2024-04-19T13_32_21_710Z-debug-0.log as follows
Because I found error like "POST /cvds" failed with error: invalid CreateCVDRequest: field CVD is empty". Could here be the root cause? |
Hi Zach, Apologize for the late reply, I have been working on a solution for the errors in comment #229 (comment). Expect some updates by next week. I'll create an internal ticket for the new |
Hi @spiritedRunning, an update on this, these unit tests were removed in favor of integration tests, these failures are no longer happening. |
Hi @ser-io , thanks for your effort! Now this error is no longer happen.
I didn't find the suitable place to submit this error, can you give some advice about this? Thanks. |
Hi Zach, the |
Hi, I tried to find the solution about this but failed, do we have other alternative method instead of bazel for building? |
Hi Zach, we are only supporting bazel. Please explore other ways to install bazel in your system following https://bazel.build/install and feel free to modify https://github.com/google/android-cuttlefish/blob/main/tools/buildutils/installbazel.sh with your findings and send us a PR. |
Hi Sergio, after I install bazel manually, the building process has been successful, and I raised a PR #607 for checking bazel installation status to prevent timeout error caused by repeated installation. |
Sorry to interrupt, but I have a question, I am building cuttlefish-base_.deb and cuttlefish-user_.deb with the following commands
But when executing the command it says "dpkg-checkbuilddeps: error: Unmet build dependencies: bazel "
I tried to run tools/buildutils/installbazel.sh but because of the proxy I can't download https://bazel.build/bazel-release.pub.gpg @spiritedRunning 兄弟你有遇到这个问题吗? |
It seems that bazel was not installed as a debian package, so the dependency from the debian builder point of view is still unmet, as it depends on the bazel package being installed in the system, not the binary being available in If you can't install the bazel package in your system you won't be able to build in a supported way. You could try deleting the bazel dependency from |
Thank you for your reply! I tried switching proxy mode and successfully downloaded bazel. |
Temporary solution until golang/go#28194 is fixed in order to retry failed fetch requests.