Skip to content

Commit

Permalink
Remove bazel_clang_tidy integration in favor of the new clang-tidy …
Browse files Browse the repository at this point in the history
…runner
  • Loading branch information
Databean committed Feb 4, 2025
1 parent e692193 commit 7b631cf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 17 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/presubmit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ jobs:
with:
name: testlogs
path: bazel-testlogs
- name: Run clang-tidy
run: cd base/cvd && bazel build //cuttlefish/... --config clang-tidy
e2e-tests-orchestration:
runs-on: ubuntu-22.04
steps:
Expand Down
5 changes: 0 additions & 5 deletions base/cvd/.bazelrc
Original file line number Diff line number Diff line change
@@ -1,6 +1 @@
build --copt=-fdiagnostics-color=always

build:clang-tidy --aspects @bazel_clang_tidy//clang_tidy:clang_tidy.bzl%clang_tidy_aspect
build:clang-tidy --output_groups=report
build:clang-tidy --@bazel_clang_tidy//:clang_tidy_config=//:clang_tidy_config
build:clang-tidy --@bazel_clang_tidy//:clang_tidy_executable=@llvm_toolchain//:clang-tidy
12 changes: 2 additions & 10 deletions base/cvd/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
# For more details, please check https://github.com/bazelbuild/bazel/issues/18958
###############################################################################

bazel_dep(name = "aspect_rules_lint", version = "1.0.8")
bazel_dep(name = "bazel_clang_tidy", dev_dependency = True)
bazel_dep(name = "bazel_skylib", version = "1.7.1")
bazel_dep(name = "aspect_rules_lint", version = "1.0.8", dev_dependency = True)
bazel_dep(name = "bazel_skylib", version = "1.7.1", dev_dependency = True)
bazel_dep(name = "boringssl", version = "0.20241024.0")
bazel_dep(name = "curl", version = "8.8.0.bcr.2")
bazel_dep(name = "fmt", version = "10.2.1")
Expand All @@ -32,13 +31,6 @@ git_override(
remote = "https://github.com/mikael-s-persson/bazel-compile-commands-extractor",
)

# https://github.com/erenon/bazel_clang_tidy
git_override(
module_name = "bazel_clang_tidy",
commit = "f23d924918c581c68cd5cda5f12b4f8198ac0c35",
remote = "https://github.com/erenon/bazel_clang_tidy.git",
)

# Configure and register the toolchain.
llvm = use_extension("@toolchains_llvm//toolchain/extensions:llvm.bzl", "llvm")
llvm.toolchain(
Expand Down

0 comments on commit 7b631cf

Please sign in to comment.