-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(tools): Add debug logging to VertexAiSearchTool #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(tools): Add debug logging to VertexAiSearchTool #3284
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @omkute10, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the debuggability of agents utilizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hello @omkute10, thank you for your contribution! Before we can merge this PR, we need to address a couple of items from our contribution guidelines:
Once these items are addressed, we can proceed with the review. Response from ADK Triaging Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds debug-level logging to the VertexAiSearchTool to provide better visibility into its configuration at runtime. The changes are well-implemented, including a helper to extract resource IDs for cleaner log messages. The unit tests have been diligently updated to verify the new logging output. My review includes suggestions to improve the robustness and consistency of the log assertions in the tests.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Problem:
When debugging agents that utilize the
VertexAiSearchTool, it's currently difficult to inspect the specific configuration parameters (datastore ID, engine ID, filter, max_results, etc.) being passed to the underlying Vertex AI Search API via theLlmRequest. This lack of visibility can hinder troubleshooting efforts related to tool configuration.Solution:
This PR enhances the
VertexAiSearchToolby adding a debug-level log statement within theprocess_llm_requestmethod. This log precisely records the parameters being used for the Vertex AI Search configuration just before it's appended to theLlmRequest.This provides developers with crucial visibility into the tool's runtime behavior when debug logging is enabled, significantly improving the debuggability of agents using this tool. Corresponding unit tests were updated to rigorously verify this new logging output using
caplog. Additionally, minor fixes were made to the tests to resolve Pydantic validation errors.Testing Plan
Unit Tests:
Summary of
pytestresults: All unit tests intests/unittests/tools/test_vertex_ai_search_tool.pyand the broader suite pass successfully after changes. (pytest tests/unittests) The updated tests specifically assert the presence and content of the new debug log messages usingcaplog.Manual End-to-End (E2E) Tests:
Verified by running a simple agent configuration locally that uses
VertexAiSearchToolwith logging level set to DEBUG. Confirmed the expected log message containing the correct parameters appears in the console output, demonstrating the feature works as intended in a basic execution flow.Checklist
Additional context
N/A