Integrate OpenTelemetry (OTel) support: 3. add telemetry support in the web server #13
+476
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalenkevich
reviewed
Nov 24, 2025
| .addOption(VERBOSE_OPTION) | ||
| .addOption(LOG_LEVEL_OPTION) | ||
| .addOption(ARTIFACT_SERVICE_URI_OPTION) | ||
| .addOption(OTEL_TO_CLOUD_OPTION) |
Collaborator
There was a problem hiding this comment.
it is not used in the action. Please remove
dev/src/server/adk_web_server.ts
Outdated
| } | ||
|
|
||
| private async setupTelemetry(): Promise<void> { | ||
| this.memoryExporter = new InMemoryExporter(this.sessionTraceDict); |
Collaborator
There was a problem hiding this comment.
this could be moved to constructor
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion!
dev/src/utils/telemetry_utils.ts
Outdated
| } | ||
| } | ||
|
|
||
| export async function setupGcpTelemetryExperimental( |
Collaborator
There was a problem hiding this comment.
does it requre to be public? can we keep this internal (remove export)?
dev/src/utils/telemetry_utils.ts
Outdated
| maybeSetOtelProviders(otelHooksToAdd, otelResource); | ||
| } | ||
|
|
||
| export async function setupTelemetryFromEnvExperimental( |
dev/src/utils/telemetry_utils.ts
Outdated
| } | ||
| } | ||
|
|
||
| export function otelEnvVarsEnabled(): boolean { |
Collaborator
There was a problem hiding this comment.
do we need to export this?
Collaborator
Author
There was a problem hiding this comment.
OK, I have removed it
…he web server Integrate OpenTelemetry (OTel) support: 3. add telemetry support in the web server - 2
mingjourney
force-pushed
the
feature/telemetry-web-server
branch
from
ff8cab2 to
c638e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate OpenTelemetry (OTel) support: 3. add telemetry support in the web server