Skip to content

cmake: support find_package(XNNPACK)#5031

Merged
copybara-service[bot] merged 1 commit intogoogle:masterfrom
ConnorBaker:feat/support-cmake-find-package
Oct 16, 2023
Merged

cmake: support find_package(XNNPACK)#5031
copybara-service[bot] merged 1 commit intogoogle:masterfrom
ConnorBaker:feat/support-cmake-find-package

Conversation

@ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Jul 4, 2023

Adds a CMake configuration file to make it possible for CMake-based projects to use find_package to consume this library.

Part of the work being done for NixOS/nixpkgs#239291.

@google-cla
Copy link

google-cla bot commented Jul 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ConnorBaker ConnorBaker force-pushed the feat/support-cmake-find-package branch 4 times, most recently from 867f66b to 5192aad Compare July 9, 2023 18:16
@ConnorBaker ConnorBaker marked this pull request as ready for review July 9, 2023 18:20
@ConnorBaker
Copy link
Contributor Author

@Maratyszcza @alankelly would either of you have a chance to review this?

@ConnorBaker ConnorBaker force-pushed the feat/support-cmake-find-package branch from 5192aad to 6f1e7d9 Compare July 14, 2023 18:23
@ConnorBaker ConnorBaker requested a review from Maratyszcza July 14, 2023 18:23
@ConnorBaker ConnorBaker force-pushed the feat/support-cmake-find-package branch 2 times, most recently from 7da6bf1 to d99deb0 Compare August 22, 2023 03:25
@ConnorBaker
Copy link
Contributor Author

Rebased, squashed, and force-pushed!

@Maratyszcza I think I answered your comments, please let me know if you have any more questions.

I apologize for the delay in getting back to you!

@waterdropw
Copy link
Contributor

I very much agree with this PR, because if i just use "xnnpack.h" and "libXNNPACK.a" after installed into /usr/local , then a lot of "undefined reference... " build error will occur!

@ConnorBaker ConnorBaker force-pushed the feat/support-cmake-find-package branch from d99deb0 to 70a5986 Compare October 15, 2023 19:42
@ConnorBaker ConnorBaker force-pushed the feat/support-cmake-find-package branch from 70a5986 to ff0af76 Compare October 15, 2023 19:45
@ConnorBaker
Copy link
Contributor Author

Quoted the path names to avoid weirdness when interpolating strings. (Yay, strings!)

Sorry for the horrible average turn around time!

@alankelly alankelly self-assigned this Oct 16, 2023
@copybara-service copybara-service bot merged commit f1bc09d into google:master Oct 16, 2023
@ConnorBaker ConnorBaker deleted the feat/support-cmake-find-package branch October 20, 2023 15:04
@ConnorBaker ConnorBaker restored the feat/support-cmake-find-package branch October 20, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants