hps_accel/stream: Update stream API #238
Conversation
| def cast(obj, src_loc_at=0, ignores_ready=False, ignores_valid=False): | ||
| if isinstance(obj, StreamDefinition): | ||
| return StreamDefinition( | ||
| paylad_type=obj.payload_type, |
There was a problem hiding this comment.
Hmm. More test cases needed, clearly.
There was a problem hiding this comment.
The new version of this function is used in the normal path, so this is now tested - at least cursorily tested.
|
I'm very much up in the air with naming. I somewhat agree with your objection to Stream, but I don't think Endpoint is quite right either - when connected, two Endpoints disappear in gateware, so they're no longer endpoints, they're actually the stream. I also want to note that, in some situations, three "Endpoints" are connected in a single Stream Happy to discuss further. |
alanvgreen
force-pushed
the
streams-again
branch
from
1177265 to
741e27a
Compare
Defines a new Stream API - remove distinction between Source and Sink - make a StreamDescription class that can be used to document whether the Stream endpoint ignores the handshaking rules. These changes were made in light of comments on amaranth-lang/amaranth#317 Signed-off-by: Alan Green <[email protected]>
Changes needed to work with Stream API Signed-off-by: Alan Green <[email protected]>
Recasts API, to use Endpoint and PayloadDefinition instead of Stream and StreamDefinition. Also removes ignores_ready and ignores_valid parameters. Signed-off-by: Alan Green <[email protected]>
alanvgreen
force-pushed
the
streams-again
branch
from
741e27a to
0d8f65d
Compare
There was a problem hiding this comment.
I was wondering about the purpose for ignores_ready and ignores_valid. I guess the idea is to have the other end raise an exception if it doesn't like being connected to streams which behave that way? But since we don't have any like that, there's no need for it now?
Yes, and also formal verification. I don't think this API was a good direction to take. There's a bit more thinking documented at amaranth-lang/amaranth#317 (comment).
I'm not sure the value outweighs the impact on the API. Even if we wanted something like this, there are probably better ways to it. |
Defines a new Stream API
the Stream endpoint ignores the handshaking rules.